t7510-signed-commit: use 'test_must_fail'
The two tests 'detect fudged signature' and 'detect fudged signature with NUL' in 't7510-signed-commit.sh' check that 'git verify-commit' errors out when encountering a forged commit, but they do so by running ! git verify-commit ... Use 'test_must_fail' instead, because that would catch potential unexpected errors like a segfault as well. Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
SZEDER Gábor committed
Jun 4, 2018 at 15:39 UTC
9dd39821e3d0adf3f160642589291965c73a529e
1 file changed
+2
-2
t/t7510-signed-commit.sh
+2
-2
@@ -145,7 +145,7 @@ test_expect_success GPG 'detect fudged signature' '
145
146
sed -e "s/seventh/7th forged/" raw >forged1 &&
147
git hash-object -w -t commit forged1 >forged1.commit &&
148
- ! git verify-commit $(cat forged1.commit) &&
148
+ test_must_fail git verify-commit $(cat forged1.commit) &&
149
git show --pretty=short --show-signature $(cat forged1.commit) >actual1 &&
150
grep "BAD signature from" actual1 &&
151
! grep "Good signature from" actual1
@@ -156,7 +156,7 @@ test_expect_success GPG 'detect fudged signature with NUL' '
156
cat raw >forged2 &&
157
echo Qwik | tr "Q" "\000" >>forged2 &&
158
git hash-object -w -t commit forged2 >forged2.commit &&
159
- ! git verify-commit $(cat forged2.commit) &&
159
+ test_must_fail git verify-commit $(cat forged2.commit) &&
160
git show --pretty=short --show-signature $(cat forged2.commit) >actual2 &&
161
grep "BAD signature from" actual2 &&
162
! grep "Good signature from" actual2