http-push: prevent format overflow warning with gcc >= 9

In function 'finish_request', inlined from 'process_response' at http-push.c:248:2: http-push.c:587:4: warning: '%s' directive argument is null [-Wformat-overflow=] 587 | fprintf(stderr, "Unable to get pack file %s\n%s", | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 588 | request->url, curl_errorstr); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ request->url is needed for the error message if there was a failure during fetch but was being cleared unnecessarily earlier. note that the leak is prevented by calling release_request unconditionally at the end. Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com> Suggested-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Carlo Marcelo Arenas Belón committed May 14, 2019 at 14:11 UTC 9dde06de130463c20f8b603ed3a3ffe10347f2f1
1 file changed +2 -2
http-push.c
+2 -2
@@ -525,8 +525,8 @@ static void finish_request(struct transfer_request *request)
525 if (request->headers != NULL)
526 curl_slist_free_all(request->headers);
527
528 - /* URL is reused for MOVE after PUT */
529 - if (request->state != RUN_PUT) {
528 + /* URL is reused for MOVE after PUT and used during FETCH */
529 + if (request->state != RUN_PUT && request->state != RUN_FETCH_PACKED) {
530 FREE_AND_NULL(request->url);
531 }
532