graph: use SWAP macro
Exchange the values of graph->columns and graph->new_columns using the macro SWAP instead of hand-rolled code. The result is shorter and easier to read. This transformation was not done by the semantic patch swap.cocci because there's an unrelated statement between the second and the last step of the exchange, so it didn't match the expected pattern. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
René Scharfe committed
Jan 28, 2017 at 22:42 UTC
9e2edd66dda418dad751d5eb2e5921e05e57cd30
1 file changed
+1
-5
graph.c
+1
-5
@@ -463,7 +463,6 @@ static void graph_update_width(struct git_graph *graph,
463
static void graph_update_columns(struct git_graph *graph)
464
{
465
struct commit_list *parent;
466
- struct column *tmp_columns;
466
int max_new_columns;
467
int mapping_idx;
468
int i, seen_this, is_commit_in_columns;
@@ -476,11 +475,8 @@ static void graph_update_columns(struct git_graph *graph)
475
* We'll re-use the old columns array as storage to compute the new
476
* columns list for the commit after this one.
477
*/
479
- tmp_columns = graph->columns;
480
- graph->columns = graph->new_columns;
478
+ SWAP(graph->columns, graph->new_columns);
479
graph->num_columns = graph->num_new_columns;
482
-
483
- graph->new_columns = tmp_columns;
480
graph->num_new_columns = 0;
481
482
/*