archive-tar: convert snprintf to xsnprintf

Commit f2f0267 (archive-tar: use xsnprintf for trivial formatting, 2015-09-24) converted cases of "sprintf" to "xsnprintf", but accidentally left one as just "snprintf". This meant that we could silently truncate the resulting buffer instead of flagging an error. In practice, this is impossible to achieve, as we are formatting a ustar checksum, which can be at most 7 characters. But the point of xsnprintf is to document and check for "should be impossible" conditions; this site was just accidentally mis-converted during f2f0267. Noticed-by: Paul Green <Paul.Green@stratus.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed May 26, 2016 at 00:28 UTC 9e6c1e91a3f06eec45f976ed3ff4e9f445cf7328
1 file changed +1 -1
archive-tar.c
+1 -1
@@ -181,7 +181,7 @@ static void prepare_header(struct archiver_args *args,
181 memcpy(header->magic, "ustar", 6);
182 memcpy(header->version, "00", 2);
183
184 - snprintf(header->chksum, sizeof(header->chksum), "%07o", ustar_header_chksum(header));
184 + xsnprintf(header->chksum, sizeof(header->chksum), "%07o", ustar_header_chksum(header));
185 }
186
187 static int write_extended_header(struct archiver_args *args,