test lib: change "error" to "BUG" as appropriate
Change two uses of "error" in test-lib-functions.sh to "BUG". In the first instance in "test_cmp_rev" the author of the "BUG" function added in [1] had another in-flight patch adding this in [2], and the two were never consolidated. In the second case in "test_atexit" added in [3] that we could have instead used "BUG" appears to have been missed. 1. 165293af3ce (tests: send "bug in the test script" errors to the script's stderr, 2018-11-19) 2. 30d0b6dccbc (test-lib-functions: make 'test_cmp_rev' more informative on failure, 2018-11-19) 3. 900721e15c4 (test-lib: introduce 'test_atexit', 2019-03-13) Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Feb 9, 2021 at 22:41 UTC
9e9c7dd6f13e9a5027538854132b9f6b6ddb6be2
1 file changed
+2
-2
t/test-lib-functions.sh
+2
-2
@@ -1105,7 +1105,7 @@ test_cmp_rev () {
1105
fi
1106
if test $# != 2
1107
then
1108
- error "bug in the test script: test_cmp_rev requires two revisions, but got $#"
1108
+ BUG "test_cmp_rev requires two revisions, but got $#"
1109
else
1110
local r1 r2
1111
r1=$(git rev-parse --verify "$1") &&
@@ -1216,7 +1216,7 @@ test_atexit () {
1216
# doing so on Bash is better than nothing (the test will
1217
# silently pass on other shells).
1218
test "${BASH_SUBSHELL-0}" = 0 ||
1219
- error "bug in test script: test_atexit does nothing in a subshell"
1219
+ BUG "test_atexit does nothing in a subshell"
1220
test_atexit_cleanup="{ $*
1221
} && (exit \"\$eval_ret\"); eval_ret=\$?; $test_atexit_cleanup"
1222
}