merge-ort: fix type of local 'clean' var in handle_content_merge ()

handle_content_merge() returns an int. Every caller of handle_content_merge() expects an int. However, we declare a local variable 'clean' that we use for the return value to be unsigned. To make matters worse, we also assign 'clean' the return value of merge_submodule() in one codepath, which is defined to return an int. It seems that the only reason to have 'clean' be unsigned was to allow a cutesy bit manipulation operation to be well-defined. Fix the type of the 'clean' local in handle_content_merge(). Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Elijah Newren committed Jun 19, 2024 at 03:00 UTC 9ed8e17d8a8c374529bb908c81f1a862f689b904
1 file changed +3 -2
merge-ort.c
+3 -2
@@ -2109,7 +2109,7 @@ static int handle_content_merge(struct merge_options *opt,
2109 * merges, which happens for example with rename/rename(2to1) and
2110 * rename/add conflicts.
2111 */
2112 - unsigned clean = 1;
2112 + int clean = 1;
2113
2114 /*
2115 * handle_content_merge() needs both files to be of the same type, i.e.
@@ -2184,7 +2184,8 @@ static int handle_content_merge(struct merge_options *opt,
2184 free(result_buf.ptr);
2185 if (ret)
2186 return -1;
2187 - clean &= (merge_status == 0);
2187 + if (merge_status > 0)
2188 + clean = 0;
2189 path_msg(opt, INFO_AUTO_MERGING, 1, path, NULL, NULL, NULL,
2190 _("Auto-merging %s"), path);
2191 } else if (S_ISGITLINK(a->mode)) {