reftable/reader: rename `reftable_new_reader()`
Rename the `reftable_new_reader()` function to `reftable_reader_new()` to match our coding guidelines. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Patrick Steinhardt committed
Aug 23, 2024 at 16:12 UTC
a0218203cdbcc4feb494074ec3d95c7c52670d09
6 files changed
+13
-13
reftable/reader.c
+2
-2
@@ -637,7 +637,7 @@ void reader_close(struct reftable_reader *r)
637
FREE_AND_NULL(r->name);
638
}
639
640
-int reftable_new_reader(struct reftable_reader **p,
640
+int reftable_reader_new(struct reftable_reader **p,
641
struct reftable_block_source *src, char const *name)
642
{
643
struct reftable_reader *rd = reftable_calloc(1, sizeof(*rd));
@@ -786,7 +786,7 @@ int reftable_reader_print_blocks(const char *tablename)
786
if (err < 0)
787
goto done;
788
789
- err = reftable_new_reader(&r, &src, tablename);
789
+ err = reftable_reader_new(&r, &src, tablename);
790
if (err < 0)
791
goto done;
792
reftable/readwrite_test.c
+3
-3
@@ -646,7 +646,7 @@ static void test_write_empty_table(void)
646
647
block_source_from_strbuf(&source, &buf);
648
649
- err = reftable_new_reader(&rd, &source, "filename");
649
+ err = reftable_reader_new(&rd, &source, "filename");
650
EXPECT_ERR(err);
651
652
reftable_reader_init_ref_iterator(rd, &it);
@@ -850,7 +850,7 @@ static void test_write_multiple_indices(void)
850
EXPECT(stats->log_stats.index_offset > 0);
851
852
block_source_from_strbuf(&source, &writer_buf);
853
- err = reftable_new_reader(&reader, &source, "filename");
853
+ err = reftable_reader_new(&reader, &source, "filename");
854
EXPECT_ERR(err);
855
856
/*
@@ -907,7 +907,7 @@ static void test_write_multi_level_index(void)
907
EXPECT(stats->ref_stats.max_index_level == 2);
908
909
block_source_from_strbuf(&source, &writer_buf);
910
- err = reftable_new_reader(&reader, &source, "filename");
910
+ err = reftable_reader_new(&reader, &source, "filename");
911
EXPECT_ERR(err);
912
913
/*
reftable/reftable-reader.h
+2
-2
@@ -23,14 +23,14 @@
23
/* The reader struct is a handle to an open reftable file. */
24
struct reftable_reader;
25
26
-/* reftable_new_reader opens a reftable for reading. If successful,
26
+/* reftable_reader_new opens a reftable for reading. If successful,
27
* returns 0 code and sets pp. The name is used for creating a
28
* stack. Typically, it is the basename of the file. The block source
29
* `src` is owned by the reader, and is closed on calling
30
* reftable_reader_destroy(). On error, the block source `src` is
31
* closed as well.
32
*/
33
-int reftable_new_reader(struct reftable_reader **pp,
33
+int reftable_reader_new(struct reftable_reader **pp,
34
struct reftable_block_source *src, const char *name);
35
36
/* Initialize a reftable iterator for reading refs. */
reftable/stack.c
+2
-2
@@ -258,7 +258,7 @@ static int reftable_stack_reload_once(struct reftable_stack *st,
258
if (err < 0)
259
goto done;
260
261
- err = reftable_new_reader(&rd, &src, name);
261
+ err = reftable_reader_new(&rd, &src, name);
262
if (err < 0)
263
goto done;
264
}
@@ -1532,7 +1532,7 @@ static void remove_maybe_stale_table(struct reftable_stack *st, uint64_t max,
1532
if (err < 0)
1533
goto done;
1534
1535
- err = reftable_new_reader(&rd, &src, name);
1535
+ err = reftable_reader_new(&rd, &src, name);
1536
if (err < 0)
1537
goto done;
1538
t/helper/test-reftable.c
+1
-1
@@ -139,7 +139,7 @@ static int dump_reftable(const char *tablename)
139
if (err < 0)
140
goto done;
141
142
- err = reftable_new_reader(&r, &src, tablename);
142
+ err = reftable_reader_new(&r, &src, tablename);
143
if (err < 0)
144
goto done;
145
t/unit-tests/t-reftable-merged.c
+3
-3
@@ -102,7 +102,7 @@ merged_table_from_records(struct reftable_ref_record **refs,
102
write_test_table(&buf[i], refs[i], sizes[i]);
103
block_source_from_strbuf(&(*source)[i], &buf[i]);
104
105
- err = reftable_new_reader(&(*readers)[i], &(*source)[i],
105
+ err = reftable_reader_new(&(*readers)[i], &(*source)[i],
106
"name");
107
check(!err);
108
}
@@ -277,7 +277,7 @@ merged_table_from_log_records(struct reftable_log_record **logs,
277
write_test_log_table(&buf[i], logs[i], sizes[i], i + 1);
278
block_source_from_strbuf(&(*source)[i], &buf[i]);
279
280
- err = reftable_new_reader(&(*readers)[i], &(*source)[i],
280
+ err = reftable_reader_new(&(*readers)[i], &(*source)[i],
281
"name");
282
check(!err);
283
}
@@ -426,7 +426,7 @@ static void t_default_write_opts(void)
426
427
block_source_from_strbuf(&source, &buf);
428
429
- err = reftable_new_reader(&rd, &source, "filename");
429
+ err = reftable_reader_new(&rd, &source, "filename");
430
check(!err);
431
432
hash_id = reftable_reader_hash_id(rd);