t: do not hide Git's exit code in tests using 'nul_to_q'
Git should not be on the left-hand side of a pipe, because it hides the exit code, and we want to make sure git does not fail. Fix all invocations of 'nul_to_q' (defined in /t/test-lib-functions.sh) using this pattern. There is one more occurrence of the pattern in t9010-svn-fe.sh which is too evolved to change it easily. All remaining test code that does not adhere to the pattern can be found with the following command: git grep -E 'git.*[^|]\|($|[^|])' Helped-by: Jeff King <peff@peff.net> Signed-off-by: Lars Schneider <larsxschneider@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Lars Schneider committed
Feb 17, 2016 at 09:57 UTC
a0578e0382f453924fd2df8ea0402b90cd01f826
2 files changed
+6
-3
t/t1300-repo-config.sh
+4
-2
@@ -957,13 +957,15 @@ Qsection.sub=section.val4
957
Qsection.sub=section.val5Q
958
EOF
959
test_expect_success '--null --list' '
960
- git config --null --list | nul_to_q >result &&
960
+ git config --null --list >result.raw &&
961
+ nul_to_q <result.raw >result &&
962
echo >>result &&
963
test_cmp expect result
964
'
965
966
test_expect_success '--null --get-regexp' '
966
- git config --null --get-regexp "val[0-9]" | nul_to_q >result &&
967
+ git config --null --get-regexp "val[0-9]" >result.raw &&
968
+ nul_to_q <result.raw >result &&
969
echo >>result &&
970
test_cmp expect result
971
'
t/t7008-grep-binary.sh
+2
-1
@@ -141,7 +141,8 @@ test_expect_success 'grep respects not-binary diff attribute' '
141
test_cmp expect actual &&
142
echo "b diff" >.gitattributes &&
143
echo "b:binQary" >expect &&
144
- git grep bin b | nul_to_q >actual &&
144
+ git grep bin b >actual.raw &&
145
+ nul_to_q <actual.raw >actual &&
146
test_cmp expect actual
147
'
148