t5523: use test_i18ngrep for negation
Replace the first form with the second one: ! grep expected actual test_i18ngrep ! expected actual The latter syntax is supported by test_i18ngrep defined in t/test-lib.sh. Although the test already passes whether GETTEXT_POSION is enabled, use the i18n grep variant for the sake of consistency and also to make obvious that those strings are subject to i18n. Signed-off-by: Vasco Almeida <vascomalmeida@sapo.pt> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Vasco Almeida committed
Jun 17, 2016 at 20:21 UTC
a1347dc00c35d4f37e0df2eceb0da6363a1dbced
1 file changed
+4
-4
t/t5523-push-upstream.sh
+4
-4
@@ -83,7 +83,7 @@ test_expect_success 'progress messages do not go to non-tty' '
83
84
# skip progress messages, since stderr is non-tty
85
git push -u upstream master >out 2>err &&
86
- ! grep "Writing objects" err
86
+ test_i18ngrep ! "Writing objects" err
87
'
88
89
test_expect_success 'progress messages go to non-tty (forced)' '
@@ -98,15 +98,15 @@ test_expect_success TTY 'push -q suppresses progress' '
98
ensure_fresh_upstream &&
99
100
test_terminal git push -u -q upstream master >out 2>err &&
101
- ! grep "Writing objects" err
101
+ test_i18ngrep ! "Writing objects" err
102
'
103
104
test_expect_success TTY 'push --no-progress suppresses progress' '
105
ensure_fresh_upstream &&
106
107
test_terminal git push -u --no-progress upstream master >out 2>err &&
108
- ! grep "Unpacking objects" err &&
109
- ! grep "Writing objects" err
108
+ test_i18ngrep ! "Unpacking objects" err &&
109
+ test_i18ngrep ! "Writing objects" err
110
'
111
112
test_expect_success TTY 'quiet push' '