bisect: fix leaking `current_bad_oid`
When reading bisect refs we read the reference mapping to the "bad" term into the global `current_bad_oid` variable. This is an allocated string, but because it is global we never have to free it. This changes though when `register_ref()` is being called multiple times, at which point we'll overwrite the previous pointer and thus make it unreachable. Fix this issue by freeing the previous value. This leak is exposed by t6030, but plugging it does not make the whole test suite pass. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Patrick Steinhardt committed
Nov 20, 2024 at 14:39 UTC
a13d4a19d2b260e27b262292f07f5f315f04e07d
1 file changed
+1
bisect.c
+1
@@ -456,6 +456,7 @@ static int register_ref(const char *refname, const char *referent UNUSED, const
456
strbuf_addstr(&good_prefix, "-");
457
458
if (!strcmp(refname, term_bad)) {
459
+ free(current_bad_oid);
460
current_bad_oid = xmalloc(sizeof(*current_bad_oid));
461
oidcpy(current_bad_oid, oid);
462
} else if (starts_with(refname, good_prefix.buf)) {