@matheusbsbs / matheus-bagliano / commits / a1dab41af4
Fork 0

Don't try to delta if target is much smaller than source

Add a new try_delta heuristic. Don't bother trying to make a delta if the target object size is much smaller (currently 1/32) than the source, as it's very likely not going to get a match. Even if it does, you will have to read at least 32x the size of the new file to reassemble it, which isn't such a good deal. This leads to a considerable performance improvement when deltifying a mix of small and large files with a very large window, because you don't have to wait for the large files to percolate out of the window before things start going fast again. Signed-off-by: Brian Downing <bdowning@lavos.net> Acked-by: Nicolas Pitre <nico@cam.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Brian Downing committed Jul 12, 2007 at 07:55 UTC a1dab41af4c575bb72231c73df26ecb2af4814d6
1 file changed +2
builtin-pack-objects.c
+2
@@ -1348,6 +1348,8 @@ static int try_delta(struct unpacked *trg, struct unpacked *src,
1348 sizediff = src_size < trg_size ? trg_size - src_size : 0;
1349 if (sizediff >= max_size)
1350 return 0;
1351 + if (trg_size < src_size / 32)
1352 + return 0;
1353
1354 /* Load data if not already done */
1355 if (!trg->data) {