contrib/examples/git-commit.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Dec 22, 2015 at 15:10 UTC
a22c9e8d9e29277f51b77aff8d0eee3945577e72
1 file changed
+4
-4
contrib/examples/git-commit.sh
+4
-4
@@ -574,10 +574,10 @@ then
574
if test "$templatefile" != ""
575
then
576
# Test whether this is just the unaltered template.
577
- if cnt=`sed -e '/^#/d' < "$templatefile" |
577
+ if cnt=$(sed -e '/^#/d' < "$templatefile" |
578
git stripspace |
579
diff "$GIT_DIR"/COMMIT_BAREMSG - |
580
- wc -l` &&
580
+ wc -l) &&
581
test 0 -lt $cnt
582
then
583
have_commitmsg=t
@@ -630,8 +630,8 @@ then
630
fi
631
if test -z "$quiet"
632
then
633
- commit=`git diff-tree --always --shortstat --pretty="format:%h: %s"\
634
- --abbrev --summary --root HEAD --`
633
+ commit=$(git diff-tree --always --shortstat --pretty="format:%h: %s"\
634
+ --abbrev --summary --root HEAD --)
635
echo "Created${initial_commit:+ initial} commit $commit"
636
fi
637
fi