help -i: properly error out if no info viewer can be found
With this commit, git help -i <cmd> prints an error message and exits non-zero instead of being silent and exit code 0. Reported by Trent W. Buck through http://bugs.debian.org/537664 Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Gerrit Pape committed
Oct 27, 2009 at 13:31 UTC
a29aa47da79cfd0ef7ee0ef423e7e5a9a3cf07bd
1 file changed
+1
builtin-help.c
+1
@@ -372,6 +372,7 @@ static void show_info_page(const char *git_cmd)
372
const char *page = cmd_to_page(git_cmd);
373
setenv("INFOPATH", system_path(GIT_INFO_PATH), 1);
374
execlp("info", "info", "gitman", page, NULL);
375
+ die("no info viewer handled the request");
376
}
377
378
static void get_html_page_path(struct strbuf *page_path, const char *page)