http-push: improve error log
When git push fails due to server-side WebDAV error, it's not easy to point to the main culprit. Additional information about exact cURL error and HTTP server response is helpful for debugging purpose. New error log helped me pinpoint failing test t5540-http-push-webdav to a missing Apache dependency in Fedora 27: https://bugzilla.redhat.com/show_bug.cgi?id=1491151 Signed-off-by: Patryk Obara <patryk.obara@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Patryk Obara committed
Jan 24, 2018 at 12:11 UTC
a2b9820ceccf2065a3d3d347e9b1cf7834f5e146
1 file changed
+4
http-push.c
+4
@@ -915,6 +915,10 @@ static struct remote_lock *lock_remote(const char *path, long timeout)
915
lock->timeout = -1;
916
}
917
XML_ParserFree(parser);
918
+ } else {
919
+ fprintf(stderr,
920
+ "error: curl result=%d, HTTP code=%ld\n",
921
+ results.curl_result, results.http_code);
922
}
923
} else {
924
fprintf(stderr, "Unable to start LOCK request\n");