commit-graph.c: don't use discarded graph_name in error
When writing a commit-graph layer, we do so in a temporary file which is renamed into place. If we fail to create a temporary file, for e.g., because we have too many open files, then 'git_mkstemp_mode' sets the pattern to the empty string, in which case we get an error something along the lines of: error: unable to create '' It's not useful to show the pattern here at all, since we (1) know the pattern is well-formed, and (2) would have already shown the dirname when trying to create the leading directories. So, replace this error with something friendlier. Signed-off-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Taylor Blau committed
Apr 23, 2020 at 15:41 UTC
a2d57e22803b1da0df95b0a88a34116209eeb6e6
1 file changed
+1
-1
commit-graph.c
+1
-1
@@ -1397,7 +1397,7 @@ static int write_commit_graph_file(struct write_commit_graph_context *ctx)
1397
1398
fd = git_mkstemp_mode(ctx->graph_name, 0444);
1399
if (fd < 0) {
1400
- error(_("unable to create '%s'"), ctx->graph_name);
1400
+ error(_("unable to create temporary graph layer"));
1401
return -1;
1402
}
1403