revert: Don't check lone argument in get_encoding
The only place get_encoding uses the global "commit" variable is when writing an error message explaining that its lone argument was NULL. Since the function's only caller ensures that a NULL argument isn't passed, we can remove this check with two beneficial consequences: 1. Since the function doesn't use the global "commit" variable any more, it won't need to change when we eliminate the global variable later in the series. 2. Translators no longer need to localize an error message that will never be shown. Suggested-by: Junio C Hamano <gitster@pobox.com> Mentored-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ramkumar Ramachandra committed
Aug 4, 2011 at 16:09 UTC
a2ec3ad28f4608bc848feaa3d087632e44842dbf
1 file changed
-3
builtin/revert.c
-3
@@ -167,9 +167,6 @@ static char *get_encoding(const char *message)
167
{
168
const char *p = message, *eol;
169
170
- if (!p)
171
- die (_("Could not read commit message of %s"),
172
- sha1_to_hex(commit->object.sha1));
170
while (*p && *p != '\n') {
171
for (eol = p + 1; *eol && *eol != '\n'; eol++)
172
; /* do nothing */