t1430: add another refs-escape test
In t1430, we check whether deleting the branch "../../foo" will delete ".git/foo". However, this is not that interesting a test; the precious file ".git/foo" does not look like a ref, so even if we did not notice the "escape" from the "refs/" hierarchy, we would fail for that reason (i.e., if you turned refname_is_safe into a noop, the test still passes). Let's add an additional test for the same thing, but with a file that actually looks like a ref. That will make sure we are exercising the refname_is_safe code. While we're at it, let's also make the code work a little harder by adding some extra paths and some empty path components. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Apr 16, 2015 at 05:04 UTC
a33729267504c7b1a63a1f05b47faea6f9e1642c
1 file changed
+8
t/t1430-bad-ref-name.sh
+8
@@ -68,6 +68,14 @@ test_expect_success 'branch -D cannot delete non-ref in .git dir' '
68
test_cmp expect .git/my-private-file
69
'
70
71
+test_expect_success 'branch -D cannot delete ref in .git dir' '
72
+ git rev-parse HEAD >.git/my-private-file &&
73
+ git rev-parse HEAD >expect &&
74
+ git branch foo/legit &&
75
+ test_must_fail git branch -D foo////./././../../../my-private-file &&
76
+ test_cmp expect .git/my-private-file
77
+'
78
+
79
test_expect_success 'branch -D cannot delete absolute path' '
80
git branch -f extra &&
81
test_must_fail git branch -D "$(pwd)/.git/refs/heads/extra" &&