silence gcc array-bounds warning

In shorten_unambiguous_ref, we build and cache a reverse-map of the rev-parse rules like this: static char **scanf_fmts; static int nr_rules; if (!nr_rules) { for (; ref_rev_parse_rules[nr_rules]; nr_rules++) ... generate scanf_fmts ... } where ref_rev_parse_rules is terminated with a NULL pointer. Compiling with "gcc -O2 -Wall" does not cause any problems, but compiling with "-O3 -Wall" generates: $ make CFLAGS='-O3 -Wall' refs.o refs.c: In function ‘shorten_unambiguous_ref’: refs.c:3379:29: warning: array subscript is above array bounds [-Warray-bounds] for (; ref_rev_parse_rules[nr_rules]; nr_rules++) Curiously, we can silence this by explicitly nr_rules to 0 in the beginning of the loop, even though the compiler should be able to tell that we follow this code path only when nr_rules is already 0. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Oct 24, 2013 at 04:45 UTC a4165851e769ebc32da48904d58f144f2d93e69a
1 file changed +1 -1
refs.c
+1 -1
@@ -1688,7 +1688,7 @@ char *shorten_unambiguous_ref(const char *ref)
1688 size_t total_len = 0;
1689
1690 /* the rule list is NULL terminated, count them first */
1691 - for (; ref_rev_parse_rules[nr_rules]; nr_rules++)
1691 + for (nr_rules = 0; ref_rev_parse_rules[nr_rules]; nr_rules++)
1692 /* no +1 because strlen("%s") < strlen("%.*s") */
1693 total_len += strlen(ref_rev_parse_rules[nr_rules]);
1694