@matheusbsbs / matheus-bagliano / commits / a4544b311e

pack-objects: ignore ambiguous object warnings

A git push process runs several processes during its run, but one includes git send-pack which calls git pack-objects and passes the known have/wants into stdin using object ids. However, the default setting for core.warnAmbiguousRefs requires git pack-objects to check for ref names matching the ref_rev_parse_rules array in refs.c. This means that every object is triggering at least six "file exists?" queries. When there are a lot of refs, this can add up significantly! I observed a simple push spending three seconds checking these paths. The fix here is similar to 4c30d50 "rev-list: disable object/refname ambiguity check with --stdin". While the get_object_list() method reads the objects from stdin, turn warn_on_object_refname_ambiguity flag (which is usually true) to false. Just for code hygiene, save away the original at the beginning and restore it once we are done. Helped-by: Jeff King <peff@peff.net> Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Derrick Stolee committed Nov 6, 2018 at 12:34 UTC a4544b311eab7c3ffd2aa96deb9be0b92df05ae2

1 file changed +6

builtin/pack-objects.c

@@ -2988,6 +2988,7 @@ static void get_object_list(int ac, const char **av)

2988 struct rev_info revs;

2989 char line[1000];

2990 int flags = 0;

2991 + int save_warning;

2992

2993 init_revisions(&revs, NULL);

2994 save_commit_buffer = 0;

@@ -2996,6 +2997,9 @@ static void get_object_list(int ac, const char **av)

2997 /* make sure shallows are read */

2998 is_repository_shallow(the_repository);

2999

3000 + save_warning = warn_on_object_refname_ambiguity;

3001 + warn_on_object_refname_ambiguity = 0;

3002 +

3003 while (fgets(line, sizeof(line), stdin) != NULL) {

3004 int len = strlen(line);

3005 if (len && line[len - 1] == '\n')

@@ -3022,6 +3026,8 @@ static void get_object_list(int ac, const char **av)

3026 die(_("bad revision '%s'"), line);

3027 }

3028

3029 + warn_on_object_refname_ambiguity = save_warning;

3030 +

3031 if (use_bitmap_index && !get_object_list_from_bitmap(&revs))

3032 return;

3033