send-email: use the three-arg form of open in recipients_cmd

Perlcritic does not want to see the trailing pipe in the two-args form of open(), i.e. open my $fh, "$cmd \Q$file\E |"; If $cmd were a single-token command name, it would make a lot more sense to use four-or-more-args form "open FILEHANDLE,MODE,CMD,ARGS" to avoid shell from expanding metacharacters in $file, but we do expect multi-word string in $to_cmd and $cc_cmd to be expanded by the shell, so we cannot rewrite it to open my $fh, "-|", $cmd, $file; for extra safety. At least, by using this in the three-arg form: open my $fh, "-|", "$cmd \Q$file\E"; we can silence Perlcritic, even though we do not gain much safety by doing so. Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ramkumar Ramachandra committed Mar 31, 2013 at 18:40 UTC a47eab03f613fa55b9e690d5354e95bc165dceee
1 file changed +1 -1
git-send-email.perl
+1 -1
@@ -1440,7 +1440,7 @@ sub recipients_cmd {
1440
1441 my $sanitized_sender = sanitize_address($sender);
1442 my @addresses = ();
1443 - open my $fh, "$cmd \Q$file\E |"
1443 + open my $fh, "-|", "$cmd \Q$file\E"
1444 or die "($prefix) Could not execute '$cmd'";
1445 while (my $address = <$fh>) {
1446 $address =~ s/^\s*//g;