http: drop the check for an empty proxy password before approving
credential_approve() already checks for a non-empty password before saving, so there's no need to do the extra check here. Signed-off-by: John Szakmeister <john@szakmeister.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
John Szakmeister committed
Mar 11, 2021 at 21:40 UTC
a4a4439fdf2fa5867b3f30040be535cff65b8a42
1 file changed
+1
-2
http.c
+1
-2
@@ -1635,8 +1635,7 @@ static int handle_curl_result(struct slot_results *results)
1635
1636
if (results->curl_result == CURLE_OK) {
1637
credential_approve(&http_auth);
1638
- if (proxy_auth.password)
1639
- credential_approve(&proxy_auth);
1638
+ credential_approve(&proxy_auth);
1639
credential_approve(&cert_auth);
1640
return HTTP_OK;
1641
} else if (results->curl_result == CURLE_SSL_CERTPROBLEM) {