upload-pack.c: do not pass confusing cb_data to mark_our_ref()
The callee does not use cb_data, and the caller is an intermediate function in a callchain that later wants to use the cb_data for its own use. Clarify the code by breaking the dataflow explicitly by not passing cb_data down to mark_our_ref(). Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Sep 17, 2013 at 16:03 UTC
a4d695de0dbaf41505cb6db44c6bb8290980398e
1 file changed
+1
-1
upload-pack.c
+1
-1
@@ -742,7 +742,7 @@ static int send_ref(const char *refname, const unsigned char *sha1, int flag, vo
742
const char *refname_nons = strip_namespace(refname);
743
unsigned char peeled[20];
744
745
- if (mark_our_ref(refname, sha1, flag, cb_data))
745
+ if (mark_our_ref(refname, sha1, flag, NULL))
746
return 0;
747
748
if (capabilities)