t-hashmap: stop calling setup() for t_intern() test
Commit f24a9b78a9 (t-hashmap: mark unused parameters in callback function, 2024-08-17) noted that the t_intern() does not need its hashmap parameter, but we have to keep it to conform to the function pointer interface of setup(). But since the only thing setup() does is create and tear down the hashmap, we can just skip calling setup() entirely for this case, and drop the unused parameters. This simplifies the code a bit. Helped-by: Ghanshyam Thakkar <shyamthakkar001@gmail.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Aug 20, 2024 at 01:18 UTC
a6bcb3ca010ed47d26dfa5d5d221f91a46887c2f
1 file changed
+2
-3
t/unit-tests/t-hashmap.c
+2
-3
@@ -322,8 +322,7 @@ static void t_alloc(struct hashmap *map, unsigned int ignore_case)
322
free(removed);
323
}
324
325
-static void t_intern(struct hashmap *map UNUSED,
326
- unsigned int ignore_case UNUSED)
325
+static void t_intern(void)
326
{
327
const char *values[] = { "value1", "Value1", "value2", "value2" };
328
@@ -357,6 +356,6 @@ int cmd_main(int argc UNUSED, const char **argv UNUSED)
356
TEST(setup(t_iterate, 0), "iterate works");
357
TEST(setup(t_iterate, 1), "iterate (case insensitive) works");
358
TEST(setup(t_alloc, 0), "grow / shrink works");
360
- TEST(setup(t_intern, 0), "string interning works");
359
+ TEST(t_intern(), "string interning works");
360
return test_done();
361
}