xopen: explicitly report creation failures

If the flags O_CREAT and O_EXCL are both given then open(2) is supposed to create the file and error out if it already exists. The error message in that case looks like this: fatal: could not open 'foo' for writing: File exists Without further context this is confusing: Why should the existence of the file pose a problem? Isn't that a requirement for writing to it? Add a more specific error message for that case to tell the user that we actually don't expect the file to preexist, so the example becomes: fatal: unable to create 'foo': File exists Signed-off-by: René Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>

René Scharfe committed Aug 25, 2021 at 22:14 UTC a7439d0f9dd291e7cc9e6c2dda19cbfdf09b62ee
1 file changed +3 -1
wrapper.c
+3 -1
@@ -193,7 +193,9 @@ int xopen(const char *path, int oflag, ...)
193 if (errno == EINTR)
194 continue;
195
196 - if ((oflag & O_RDWR) == O_RDWR)
196 + if ((oflag & (O_CREAT | O_EXCL)) == (O_CREAT | O_EXCL))
197 + die_errno(_("unable to create '%s'"), path);
198 + else if ((oflag & O_RDWR) == O_RDWR)
199 die_errno(_("could not open '%s' for reading and writing"), path);
200 else if ((oflag & O_WRONLY) == O_WRONLY)
201 die_errno(_("could not open '%s' for writing"), path);