t/check-non-portable-shell: detect "FOO= shell_func", too
Just like assigning a nonempty value, assigning an empty value to a shell variable when calling a function produces non-portable behavior: in some shells, the assignment lasts for the duration of the function invocation, and in others, it persists after the function returns. Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jonathan Nieder committed
Dec 26, 2019 at 11:57 UTC
a7fbf12f2f31cb5aefb4fe7f467564be32c62968
1 file changed
+1
-1
t/check-non-portable-shell.pl
+1
-1
@@ -46,7 +46,7 @@ while (<>) {
46
/(?:\$\(seq|^\s*seq\b)/ and err 'seq is not portable (use test_seq)';
47
/\bgrep\b.*--file\b/ and err 'grep --file FILE is not portable (use grep -f FILE)';
48
/\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (use FOO=bar && export FOO)';
49
- /^\s*([A-Z0-9_]+=(\w+|(["']).*?\3)\s+)+(\w+)/ and exists($func{$4}) and
49
+ /^\s*([A-Z0-9_]+=(\w*|(["']).*?\3)\s+)+(\w+)/ and exists($func{$4}) and
50
err '"FOO=bar shell_func" assignment extends beyond "shell_func"';
51
$line = '';
52
# this resets our $. for each file