pager: do not dup2 stderr if it is already redirected
An earlier commit 61b8050 (sending errors to stdout under $PAGER, 2008-02-16) avoided losing the error messages that are sent to the standard error when $PAGER is in effect by dup2'ing fd 2 to the pager. his way, showing a tag object that points to a bad object: $ git show tag-foo would give the error message to the pager. However, it was not quite right if the user did: $ git show 2>error.log tag-foo i.e. use the pager but store the errors in a separate file. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Dec 15, 2008 at 00:33 UTC
a8335024c294db470e16e9df3aaa346bfcfbeacb
1 file changed
+2
-1
pager.c
+2
-1
@@ -102,7 +102,8 @@ void setup_pager(void)
102
103
/* original process continues, but writes to the pipe */
104
dup2(pager_process.in, 1);
105
- dup2(pager_process.in, 2);
105
+ if (isatty(2))
106
+ dup2(pager_process.in, 2);
107
close(pager_process.in);
108
109
/* this makes sure that the parent terminates after the pager */