setup: unset ref storage when reinitializing repository version

When reinitializing a repository's version we may end up unsetting the hash algorithm when it matches the default hash algorithm. If we didn't do that then the previously configured value might remain intact. While the same issue exists for the ref storage extension, we don't do this here. This has been fine for most of the part because it is not supported to re-initialize a repository with a different ref storage format anyway. We're about to introduce a new command to migrate ref storages though, so this is about to become an issue there. Prepare for this and unset the ref storage format when reinitializing a repository with the "files" format. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Patrick Steinhardt committed Jun 6, 2024 at 07:28 UTC a83f7f51e172704a445f481d550a3cee962f1dc4
1 file changed +2
setup.c
+2
@@ -2028,6 +2028,8 @@ void initialize_repository_version(int hash_algo,
2028 if (ref_storage_format != REF_STORAGE_FORMAT_FILES)
2029 git_config_set("extensions.refstorage",
2030 ref_storage_format_to_name(ref_storage_format));
2031 + else if (reinit)
2032 + git_config_set_gently("extensions.refstorage", NULL);
2033 }
2034
2035 static int is_reinit(void)