@matheusbsbs / matheus-bagliano / commits / a91ef6e75b
Fork 0

fix index-pack with packs >4GB containing deltas on 32-bit machines

This probably hasn't been properly tested before. Here's a script to create a 8GB repo with the necessary characteristics (copy the test-genrandom executable from the Git build tree to /tmp first): ----- #!/bin/bash git init git config core.compression 0 # create big objects with no deltas for i in $(seq -w 1 2 63) do echo $i /tmp/test-genrandom $i 268435456 > file_$i git add file_$i rm file_$i echo "file_$i -delta" >> .gitattributes done # create "deltifiable" objects in between big objects for i in $(seq -w 2 2 64) do echo "$i $i $i" >> grow cp grow file_$i git add file_$i rm file_$i done rm grow # create a pack with them git commit -q -m "commit of big objects interlaced with small deltas" git repack -a -d ----- Then clone this repo over the Git protocol. Signed-off-by: Nicolas Pitre <nico@cam.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Nicolas Pitre committed Nov 10, 2007 at 23:29 UTC a91ef6e75b897a255cc17b70014a39e68dd54c7a
1 file changed +1 -1
index-pack.c
+1 -1
@@ -254,7 +254,7 @@ static void *unpack_raw_entry(struct object_entry *obj, union delta_base *delta_
254
255 static void *get_data_from_pack(struct object_entry *obj)
256 {
257 - unsigned long from = obj[0].idx.offset + obj[0].hdr_size;
257 + off_t from = obj[0].idx.offset + obj[0].hdr_size;
258 unsigned long len = obj[1].idx.offset - from;
259 unsigned long rdy = 0;
260 unsigned char *src, *data;