use get_cached_commit_buffer where appropriate
Some call sites check commit->buffer to see whether we have a cached buffer, and if so, do some work with it. In the long run we may want to switch these code paths to make their decision on a different boolean flag (because checking the cache may get a little more expensive in the future). But for now, we can easily support them by converting the calls to use get_cached_commit_buffer. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Jun 10, 2014 at 17:40 UTC
a97934d8205772ffd2a528a9e970af7dec725012
3 files changed
+3
-3
builtin/rev-list.c
+1
-1
@@ -106,7 +106,7 @@ static void show_commit(struct commit *commit, void *data)
106
else
107
putchar('\n');
108
109
- if (revs->verbose_header && commit->buffer) {
109
+ if (revs->verbose_header && get_cached_commit_buffer(commit)) {
110
struct strbuf buf = STRBUF_INIT;
111
struct pretty_print_context ctx = {0};
112
ctx.abbrev = revs->abbrev;
log-tree.c
+1
-1
@@ -588,7 +588,7 @@ void show_log(struct rev_info *opt)
588
show_mergetag(opt, commit);
589
}
590
591
- if (!commit->buffer)
591
+ if (!get_cached_commit_buffer(commit))
592
return;
593
594
if (opt->show_notes) {
object.c
+1
-1
@@ -197,7 +197,7 @@ struct object *parse_object_buffer(const unsigned char *sha1, enum object_type t
197
if (commit) {
198
if (parse_commit_buffer(commit, buffer, size))
199
return NULL;
200
- if (!commit->buffer) {
200
+ if (!get_cached_commit_buffer(commit)) {
201
set_commit_buffer(commit, buffer);
202
*eaten_p = 1;
203
}