@matheusbsbs / matheus-bagliano / commits / a9eb90aab5

gitweb: squelch "uninitialized value" warning

git_object() chomps $type that is read from "cat-file -t", but it does so before checking if $type is defined, resulting in a Perl warning in the server error log: gitweb.cgi: Use of uninitialized value $type in scalar chomp at [...]/gitweb.cgi line 7579., referer: [...] when trying to access a non-existing commit, for example: http://HOST/?p=PROJECT.git;a=commit;h=NON_EXISTING_COMMIT Check the value in $type before chomping. This will cause us to call href with its action parameter set to undef when formulating the URL to redirect to, but that is harmless, as the function treats a parameter that set to undef as if it does not exist. Signed-off-by: Øyvind A. Holm <sunny@sunbase.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Øyvind A. Holm committed Jan 12, 2016 at 04:31 UTC a9eb90aab5922e08a26c439806c80faa80f7c26d

1 file changed +1 -1

gitweb/gitweb.perl

+1 -1

@@ -7576,7 +7576,7 @@ sub git_object {

7576 git_cmd(), 'cat-file', '-t', $object_id) . ' 2> /dev/null'

7577 or die_error(404, "Object does not exist");

7578 $type = <$fd>;

7579 - chomp $type;

7579 + defined $type && chomp $type;

7580 close $fd

7581 or die_error(404, "Object does not exist");

7582