@matheusbsbs / matheus-bagliano / commits / aa27e46111
Fork 0

git-show: Reject native ref

So when we do git show v1.4.4..v1.5.0 that's an illogical thing to do, since "git show" is defined to be a non-revision-walking action, which means the range operator be pointless and wrong. The fact that we happily accept it (and then _only_ show v1.5.0, which is the positive end of the range) is quite arguably not very logical. We should complain, and say that you can only do "no_walk" with positive refs. Negative object refs really don't make any sense unless you walk the obejct list (or you're "git diff" and know about ranges explicitly). Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Junio C Hamano <junkio@cox.net>

Linus Torvalds committed Feb 27, 2007 at 16:22 UTC aa27e46111a777ae8b11e00675e13b1a9cde7fc2
1 file changed +2
revision.c
+2
@@ -116,6 +116,8 @@ void mark_parents_uninteresting(struct commit *commit)
116
117 void add_pending_object(struct rev_info *revs, struct object *obj, const char *name)
118 {
119 + if (revs->no_walk && (obj->flags & UNINTERESTING))
120 + die("object ranges do not make sense when not walking revisions");
121 add_object_array(obj, name, &revs->pending);
122 if (revs->reflog_info && obj->type == OBJ_COMMIT)
123 add_reflog_for_walk(revs->reflog_info,