t1006: test cat-file --batch-all-objects with duplicates

The test for --batch-all-objects in t1006 covers a variety of object storage situations, but one thing it doesn't cover is that we avoid mentioning duplicate objects. We won't have any because running "git repack -ad" will have packed them all and deleted the loose ones. This does work (because we sort and de-dup the output list), but it's good to include it in our test. And doubly so for when we add an unordered mode which has to de-dup in a different way. Note that we cannot just re-create one of the objects, as Git will omit the write of an object that is already present. However, we can create a new pack with one of the objects, which forces the duplication. One alternative would be to just use "git repack -a" instead of "-ad". But then _every_ object would be duplicated as loose and packed, and we might miss a bug that omits packed objects (because we'd show their loose counterparts). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Aug 10, 2018 at 19:16 UTC aa2f5ef5004704cd01282a1f1a9f99459c9dc021
1 file changed +4 -2
t/t1006-cat-file.sh
+4 -2
@@ -550,8 +550,8 @@ test_expect_success 'git cat-file --batch --follow-symlink returns correct sha a
550 test_expect_success 'cat-file --batch-all-objects shows all objects' '
551 # make new repos so we know the full set of objects; we will
552 # also make sure that there are some packed and some loose
553 - # objects, some referenced and some not, and that there are
554 - # some available only via alternates.
553 + # objects, some referenced and some not, some duplicates, and that
554 + # there are some available only via alternates.
555 git init all-one &&
556 (
557 cd all-one &&
@@ -567,6 +567,8 @@ test_expect_success 'cat-file --batch-all-objects shows all objects' '
567 cd all-two &&
568 echo local-unref | git hash-object -w --stdin
569 ) >>expect.unsorted &&
570 + git -C all-two rev-parse HEAD:file |
571 + git -C all-two pack-objects .git/objects/pack/pack &&
572 sort <expect.unsorted >expect &&
573 git -C all-two cat-file --batch-all-objects \
574 --batch-check="%(objectname)" >actual &&