git-svn: drop FakeTerm hack
Drop the FakeTerm hack, just like dfd46bae (send-email: drop FakeTerm hack, 2023-08-08) did, for exactly the same reason. It has been obsolete in git-svn since 30d45f798d (git-svn: delay term initialization, 2014-09-14). Note that unlike send-email, we already make sure to load Term::ReadLine only once. So this is just a cleanup, and not fixing any bug. Signed-off-by: Wesley Schwengle <wesleys@opperschaap.net> Helped-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Wesley Schwengle committed
Aug 30, 2023 at 15:32 UTC
aa4b83dd5e8e709f173027fc0fbbedbaf7c43d12
1 file changed
+2
-18
git-svn.perl
+2
-18
@@ -297,28 +297,12 @@ my %cmd = (
297
{} ],
298
);
299
300
-package FakeTerm;
301
-sub new {
302
- my ($class, $reason) = @_;
303
- return bless \$reason, shift;
304
-}
305
-sub readline {
306
- my $self = shift;
307
- die "Cannot use readline on FakeTerm: $$self";
308
-}
309
-package main;
310
-
300
my $term;
301
sub term_init {
313
- $term = eval {
314
- require Term::ReadLine;
315
- $ENV{"GIT_SVN_NOTTY"}
302
+ require Term::ReadLine;
303
+ $term = $ENV{"GIT_SVN_NOTTY"}
304
? new Term::ReadLine 'git-svn', \*STDIN, \*STDOUT
305
: new Term::ReadLine 'git-svn';
318
- };
319
- if ($@) {
320
- $term = new FakeTerm "$@: going non-interactive";
321
- }
306
}
307
308
my $cmd;