@matheusbsbs / matheus-bagliano / commits / abfbff61ef

tag: fix sign_buffer() call to create a signed tag

The command "git tag -s" internally calls sign_buffer() to make a cryptographic signature using the chosen backend like GPG and SSH. The internal helper functions used by "git tag" implementation seem to use a "negative return values are errors, zero or positive return values are not" convention, and there are places (e.g., verify_tag() that calls gpg_verify_tag()) that these internal helper functions translate return values that signal errors to conform to this convention, but do_sign() that calls sign_buffer() forgets to do so. Fix it, so that a failed call to sign_buffer() that can return the exit status from pipe_command() will not be overlooked. Reported-by: Sergey Kosukhin <skosukhin@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Junio C Hamano committed Feb 7, 2024 at 10:46 UTC abfbff61efc4d91dc964eb2360760fa640ad0f0f

2 files changed +2 -2

builtin/tag.c

+1 -1

@@ -176,7 +176,7 @@ static int verify_tag(const char *name, const char *ref UNUSED,

176

177 static int do_sign(struct strbuf *buffer)

178 {

179 - return sign_buffer(buffer, buffer, get_signing_key());

179 + return sign_buffer(buffer, buffer, get_signing_key()) ? -1 : 0;

180 }

181

182 static const char tag_template[] =

gpg-interface.h

+1 -1

@@ -66,7 +66,7 @@ size_t parse_signed_buffer(const char *buf, size_t size);

66 * Create a detached signature for the contents of "buffer" and append

67 * it after "signature"; "buffer" and "signature" can be the same

68 * strbuf instance, which would cause the detached signature appended

69 - * at the end.

69 + * at the end. Returns 0 on success, non-zero on failure.

70 */

71 int sign_buffer(struct strbuf *buffer, struct strbuf *signature,

72 const char *signing_key);