builtin/name-rev: fix various trivial memory leaks
There are several structures that we don't release after `cmd_name_rev()` is done. Plug those leaks. Signed-off-by: Patrick Steinhardt <ps@pks.im> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Patrick Steinhardt committed
Aug 1, 2024 at 12:38 UTC
ac3b143370e7bdc5be639ecdff4392e5dc6b324c
3 files changed
+6
-2
builtin/name-rev.c
+4
-2
@@ -677,7 +677,9 @@ int cmd_name_rev(int argc, const char **argv, const char *prefix)
677
always, allow_undefined, data.name_only);
678
}
679
680
- UNLEAK(string_pool);
681
- UNLEAK(revs);
680
+ string_list_clear(&data.ref_filters, 0);
681
+ string_list_clear(&data.exclude_filters, 0);
682
+ mem_pool_discard(&string_pool, 0);
683
+ object_array_clear(&revs);
684
return 0;
685
}
t/t6007-rev-list-cherry-pick-file.sh
+1
@@ -5,6 +5,7 @@ test_description='test git rev-list --cherry-pick -- file'
5
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
6
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
7
8
+TEST_PASSES_SANITIZE_LEAK=true
9
. ./test-lib.sh
10
11
# A---B---D---F
t/t6120-describe.sh
+1
@@ -14,6 +14,7 @@ test_description='test describe'
14
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
15
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
16
17
+TEST_PASSES_SANITIZE_LEAK=true
18
. ./test-lib.sh
19
20
check_describe () {