@matheusbsbs / matheus-bagliano / commits / acb0f6f337
Fork 0

gitweb.cgi: git_blame2: slight optimization reading the blame lines

Eliminate git_read_blame_line() -- move that code inline and optimize it. Signed-off-by: Luben Tuikov <ltuikov@yahoo.com> Signed-off-by: Junio C Hamano <junkio@cox.net>

Luben Tuikov committed Jul 23, 2006 at 14:17 UTC acb0f6f33760b43c1fc9617a45346ab3738f021a
1 file changed +5 -14
gitweb/gitweb.cgi
+5 -14
@@ -1252,15 +1252,6 @@ sub git_tag {
1252 git_footer_html();
1253 }
1254
1255 -sub git_read_blame_line {
1256 - my %bl;
1257 - $_ = shift;
1258 -
1259 - ($bl{'hash'}, $bl{'lineno'}, $bl{'data'}) = /^([0-9a-fA-F]{40}).*?(\d+)\)\s{1}(\s*.*)/;
1260 -
1261 - return %bl;
1262 -}
1263 -
1255 sub git_blame2 {
1256 my $fd;
1257 my $ftype;
@@ -1302,12 +1293,12 @@ sub git_blame2 {
1293 print "<div class=\"page_body\">\n";
1294 print "<table class=\"blame\">\n";
1295 print "<tr><th>Commit</th><th>Line</th><th>Data</th></tr>\n";
1305 - while (my $line = <$fd>) {
1306 - my %blame_line = git_read_blame_line($line);
1307 - my $full_rev = $blame_line{'hash'};
1296 + while (<$fd>) {
1297 + /^([0-9a-fA-F]{40}).*?(\d+)\)\s{1}(\s*.*)/;
1298 + my $full_rev = $1;
1299 my $rev = substr($full_rev, 0, 8);
1309 - my $lineno = $blame_line{'lineno'};
1310 - my $data = $blame_line{'data'};
1300 + my $lineno = $2;
1301 + my $data = $3;
1302
1303 if (!defined $last_rev) {
1304 $last_rev = $full_rev;