tree-diff: diff_tree() should now be static
We reworked all its users to use the functionality through diff_tree_sha1 variant in recent patches (see "tree-diff: allow diff_tree_sha1 to accept NULL sha1" and what comes next). diff_tree() is now not used outside tree-diff.c - make it static. Signed-off-by: Kirill Smelkov <kirr@mns.spb.ru> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Kirill Smelkov committed
Feb 24, 2014 at 20:21 UTC
ad6f3cc7d2eaec5247b39e9dca8e55a0f98123e7
2 files changed
+2
-4
diff.h
-2
@@ -189,8 +189,6 @@ const char *diff_line_prefix(struct diff_options *);
189
190
extern const char mime_boundary_leader[];
191
192
-extern int diff_tree(struct tree_desc *t1, struct tree_desc *t2,
193
- const char *base, struct diff_options *opt);
192
extern int diff_tree_sha1(const unsigned char *old, const unsigned char *new,
193
const char *base, struct diff_options *opt);
194
extern int diff_root_tree_sha1(const unsigned char *new, const char *base,
tree-diff.c
+2
-2
@@ -141,8 +141,8 @@ static void skip_uninteresting(struct tree_desc *t, struct strbuf *base,
141
}
142
}
143
144
-int diff_tree(struct tree_desc *t1, struct tree_desc *t2,
145
- const char *base_str, struct diff_options *opt)
144
+static int diff_tree(struct tree_desc *t1, struct tree_desc *t2,
145
+ const char *base_str, struct diff_options *opt)
146
{
147
struct strbuf base;
148
int baselen = strlen(base_str);