t/t6015-rev-list-show-all-parents.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Jan 7, 2016 at 14:51 UTC
ae4c094e3744de5b7ec97c8edada78fa9adf9fa5
1 file changed
+3
-3
t/t6015-rev-list-show-all-parents.sh
+3
-3
@@ -6,11 +6,11 @@ test_description='--show-all --parents does not rewrite TREESAME commits'
6
7
test_expect_success 'set up --show-all --parents test' '
8
test_commit one foo.txt &&
9
- commit1=`git rev-list -1 HEAD` &&
9
+ commit1=$(git rev-list -1 HEAD) &&
10
test_commit two bar.txt &&
11
- commit2=`git rev-list -1 HEAD` &&
11
+ commit2=$(git rev-list -1 HEAD) &&
12
test_commit three foo.txt &&
13
- commit3=`git rev-list -1 HEAD`
13
+ commit3=$(git rev-list -1 HEAD)
14
'
15
16
test_expect_success '--parents rewrites TREESAME parents correctly' '