grep.c: do "if (bool && memchr())" not "if (memchr() && bool)"
Change code in compile_regexp() to check the cheaper boolean "!opt->pcre2" condition before the "memchr()" search. This doesn't noticeably optimize anything, but makes the code more obvious and conventional. The line wrapping being added here also makes a subsequent commit smaller. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Feb 16, 2022 at 01:00 UTC
ae807d778f502c81ec55897ac6d1f42ef3a4e23b
1 file changed
+2
-1
grep.c
+2
-1
@@ -492,7 +492,8 @@ static void compile_regexp(struct grep_pat *p, struct grep_opt *opt)
492
p->ignore_case = opt->ignore_case;
493
p->fixed = opt->fixed;
494
495
- if (memchr(p->pattern, 0, p->patternlen) && !opt->pcre2)
495
+ if (!opt->pcre2 &&
496
+ memchr(p->pattern, 0, p->patternlen))
497
die(_("given pattern contains NULL byte (via -f <file>). This is only supported with -P under PCRE v2"));
498
499
p->is_fixed = is_fixed(p->pattern, p->patternlen);