parseopt: fix :(optional) at command line to only ignore missing files
Unlike the configuration option magic, the parseopt code also ignores empty files: compare implementations from ccfcaf399f (parseopt: values of pathname type can be prefixed with :(optional), 2025-09-28) and 749d6d166d (config: values of pathname type can be prefixed with :(optional), 2025-09-28). Unify the 2 by not ignoring empty files, which is less surprising and the intended semantics from the first patch for config. Suggested-by: Phillip Wood <phillip.wood@dunelm.org.uk> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
D. Ben Knoble committed
Nov 2, 2025 at 11:17 UTC
aece3bc266d3edf3a2710799876ce538561b5fba
1 file changed
+1
-1
parse-options.c
+1
-1
@@ -226,7 +226,7 @@ static enum parse_opt_result do_get_value(struct parse_opt_ctx_t *p,
226
if (!value)
227
is_optional = 0;
228
value = fix_filename(p->prefix, value);
229
- if (is_optional && is_empty_or_missing_file(value)) {
229
+ if (is_optional && is_missing_file(value)) {
230
free((char *)value);
231
} else {
232
FREE_AND_NULL(*(char **)opt->value);