log: drop unused "len" from show_tagger()
We pass the length of the found "tagger" line to show_tagger(), but it does not use it; instead, it passes the string to pp_user_info(), which reads until newline or NUL. This is OK for our purposes because we always read the object contents into a buffer with an extra NUL (and indeed, our sole caller already relies on this by using starts_with). Let's drop the ignored parameter. And while we're touching the caller, let's use skip_prefix() to avoid a magic number. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Mar 20, 2019 at 04:14 UTC
af117077d38af01f585adb16ded9deccb559b0b6
1 file changed
+4
-4
builtin/log.c
+4
-4
@@ -490,7 +490,7 @@ int cmd_whatchanged(int argc, const char **argv, const char *prefix)
490
return cmd_log_walk(&rev);
491
}
492
493
-static void show_tagger(char *buf, int len, struct rev_info *rev)
493
+static void show_tagger(const char *buf, struct rev_info *rev)
494
{
495
struct strbuf out = STRBUF_INIT;
496
struct pretty_print_context pp = {0};
@@ -546,11 +546,11 @@ static int show_tag_object(const struct object_id *oid, struct rev_info *rev)
546
assert(type == OBJ_TAG);
547
while (offset < size && buf[offset] != '\n') {
548
int new_offset = offset + 1;
549
+ const char *ident;
550
while (new_offset < size && buf[new_offset++] != '\n')
551
; /* do nothing */
551
- if (starts_with(buf + offset, "tagger "))
552
- show_tagger(buf + offset + 7,
553
- new_offset - offset - 7, rev);
552
+ if (skip_prefix(buf + offset, "tagger ", &ident))
553
+ show_tagger(ident, rev);
554
offset = new_offset;
555
}
556