check-builtins.sh: use the $(...) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Elia Pinto committed
Mar 25, 2014 at 10:22 UTC
b09d8552bd04b17c20f89b73e09206719f9e7b84
1 file changed
+2
-2
check-builtins.sh
+2
-2
@@ -14,8 +14,8 @@ sort |
14
bad=0
15
while read builtin
16
do
17
- base=`expr "$builtin" : 'git-\(.*\)'`
18
- x=`sed -ne 's/.*{ "'$base'", \(cmd_[^, ]*\).*/'$base' \1/p' git.c`
17
+ base=$(expr "$builtin" : 'git-\(.*\)')
18
+ x=$(sed -ne 's/.*{ "'$base'", \(cmd_[^, ]*\).*/'$base' \1/p' git.c)
19
if test -z "$x"
20
then
21
echo "$base is builtin but not listed in git.c command list"