t6120: further modernize
There is absolutely no reason why a pattern given to grep to find 'warning: --stdin is deprecated' must be quoted within a pair of single quotes, or the pattern to look for the literal string as ERE. Quote the test body with a pair of single quotes like everybody else, and quote the needle string in a pair of double quotes. Also use test_grep instead of "grep -E". Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Mar 11, 2025 at 14:25 UTC
b0db79892891810249702474e5bd3ca19b8fc558
1 file changed
+3
-3
t/t6120-describe.sh
+3
-3
@@ -298,11 +298,11 @@ test_expect_success 'name-rev --annotate-stdin' '
298
test_cmp expect actual
299
'
300
301
-test_expect_success 'name-rev --stdin deprecated' "
301
+test_expect_success 'name-rev --stdin deprecated' '
302
git rev-list --all >list &&
303
git name-rev --stdin <list 2>actual &&
304
- grep -E 'warning: --stdin is deprecated' actual
305
-"
304
+ test_grep "warning: --stdin is deprecated" actual
305
+'
306
307
test_expect_success 'describe --contains with the exact tags' '
308
echo "A^0" >expect &&