@matheusbsbs / matheus-bagliano / commits / b0e621adfd
Fork 0

script with rev-list instead of log

Because log.decorate now shows decorations for --pretty=oneline, we must explicitly turn it off when scripting. Otherwise, users with log.decorate set will get cruft like: $ git stash Saved working directory and index state WIP on master: 2c1f7f5 (HEAD, master) commit subject Instead of adding --no-decorate to the log command line, let's just use the rev-list plumbing interface instead, which does the right thing. git-submodule has a similar call. Since it just counts the commit lines, nothing is broken, but let's switch it, too, for the sake of consistency and cleanliness. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Jeff King committed Apr 8, 2010 at 15:42 UTC b0e621adfd5a60b7cbe95e59f09c87f0870321cb
2 files changed +2 -2
git-stash.sh
+1 -1
@@ -57,7 +57,7 @@ create_stash () {
57 # state of the base commit
58 if b_commit=$(git rev-parse --verify HEAD)
59 then
60 - head=$(git log --no-color --abbrev-commit --pretty=oneline -n 1 HEAD --)
60 + head=$(git rev-list --oneline -n 1 HEAD --)
61 else
62 die "You do not have the initial commit yet"
63 fi
git-submodule.sh
+1 -1
@@ -643,7 +643,7 @@ cmd_summary() {
643 range=$sha1_dst
644 fi
645 GIT_DIR="$name/.git" \
646 - git log --pretty=oneline --first-parent $range | wc -l
646 + git rev-list --first-parent $range -- | wc -l
647 )
648 total_commits=" ($(($total_commits + 0)))"
649 ;;