branch -m/-M: remove undocumented RENAMED-REF
The commit message for c976d41 (git-branch: add options and tests for branch renaming, 2006-11-28) mentions RENAME_REF but otherwise this is not documented anywhere, and it does not appear in any of the tests. Worse yet, the name of the actual file is "RENAMED-REF". This was supposed to hold the commit object name at the tip of the branch the most recent "branch -m/-M" renamed, but that is not necessary in order to be able to recover from a mistake. Even when "branch -M A B" overwrites an existing branch B, what is kept in RENAMED-REF is the commit at the tip of the original branch A, not the commit B from the now-lost branch. Just remove this unused "feature". Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Oct 12, 2011 at 09:42 UTC
b0eab01a4824d9b6bcf23b51881fdc94ab3d38ec
1 file changed
-8
refs.c
-8
@@ -786,7 +786,6 @@ int delete_ref(const char *refname, unsigned char *sha1)
786
787
int rename_ref(const char *oldref, const char *newref)
788
{
789
- static const char renamed_ref[] = "RENAMED-REF";
789
unsigned char sha1[20], orig_sha1[20];
790
int flag = 0, logmoved = 0;
791
struct ref_lock *lock;
@@ -809,13 +808,6 @@ int rename_ref(const char *oldref, const char *newref)
808
if (snprintf(msg, sizeof(msg), "renamed %s to %s", oldref, newref) > sizeof(msg))
809
return error("Refnames to long");
810
812
- lock = lock_ref_sha1_basic(renamed_ref, NULL, NULL);
813
- if (!lock)
814
- return error("unable to lock %s", renamed_ref);
815
- lock->force_write = 1;
816
- if (write_ref_sha1(lock, orig_sha1, msg))
817
- return error("unable to save current sha1 in %s", renamed_ref);
818
-
811
if (log && rename(git_path("logs/%s", oldref), git_path("tmp-renamed-log")))
812
return error("unable to move logfile logs/%s to tmp-renamed-log: %s",
813
oldref, strerror(errno));