send-email: pass smtp hostname and port to Authen::SASL
Starting from version 2.2000, Authen::SASL supports passing the SMTP server hostname and port to the OAUTHBEARER string passed via SMTP AUTH. Add support for the same in git-send-email. It's safe to add the new parameters unconditionally as older versions of Authen::SASL will simply ignore them without any error. Something similar is already being done for the authname parameter, which is not supported by every authentication mechanism. This can be understood as declaring a variable but not using at all. Link: https://metacpan.org/pod/Authen::SASL::Perl::OAUTHBEARER Signed-off-by: Aditya Garg <gargaditya08@live.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Aditya Garg committed
Mar 5, 2026 at 17:01 UTC
b10fb23d52425644b8c3bb9b7277cb3328a73c16
1 file changed
+2
git-send-email.perl
+2
@@ -1474,6 +1474,8 @@ sub smtp_auth_maybe {
1474
user => $cred->{'username'},
1475
pass => $cred->{'password'},
1476
authname => $cred->{'username'},
1477
+ host => $smtp_server,
1478
+ (defined $smtp_server_port ? (port => $smtp_server_port) : ()),
1479
}
1480
);
1481
$result = $smtp->auth($sasl);