rebase: apply cocci patch
Favor oideq() over !oidcmp() when checking for equality. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Junio C Hamano committed
Nov 1, 2018 at 21:44 UTC
b17ca8f94deb6e6c83ae705dcf712bf38a03ee4e
1 file changed
+1
-1
builtin/rebase.c
+1
-1
@@ -689,7 +689,7 @@ static int can_fast_forward(struct commit *onto, struct object_id *head_oid,
689
merge_bases = get_merge_bases(onto, head);
690
if (merge_bases && !merge_bases->next) {
691
oidcpy(merge_base, &merge_bases->item->object.oid);
692
- res = !oidcmp(merge_base, &onto->object.oid);
692
+ res = oideq(merge_base, &onto->object.oid);
693
} else {
694
oidcpy(merge_base, &null_oid);
695
res = 0;