transport-helper: remove name parameter
Commit 266f1fdfa (transport-helper: be quiet on read errors from helpers, 2013-06-21) removed a call to 'die()' which printed the name of the remote helper passed in to the 'recvline_fh()' function using the 'name' parameter. Once the call to 'die()' was removed the parameter was no longer necessary but wasn't removed. Clean up 'recvline_fh()' parameter list by removing the 'name' parameter. Signed-off-by: Brandon Williams <bmwill@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Brandon Williams committed
Mar 15, 2018 at 10:31 UTC
b1c2edfc18028169c5e64a8320b0877cdcbf3397
1 file changed
+3
-3
transport-helper.c
+3
-3
@@ -49,7 +49,7 @@ static void sendline(struct helper_data *helper, struct strbuf *buffer)
49
die_errno("Full write to remote helper failed");
50
}
51
52
-static int recvline_fh(FILE *helper, struct strbuf *buffer, const char *name)
52
+static int recvline_fh(FILE *helper, struct strbuf *buffer)
53
{
54
strbuf_reset(buffer);
55
if (debug)
@@ -67,7 +67,7 @@ static int recvline_fh(FILE *helper, struct strbuf *buffer, const char *name)
67
68
static int recvline(struct helper_data *helper, struct strbuf *buffer)
69
{
70
- return recvline_fh(helper->out, buffer, helper->name);
70
+ return recvline_fh(helper->out, buffer);
71
}
72
73
static void write_constant(int fd, const char *str)
@@ -586,7 +586,7 @@ static int process_connect_service(struct transport *transport,
586
goto exit;
587
588
sendline(data, &cmdbuf);
589
- if (recvline_fh(input, &cmdbuf, name))
589
+ if (recvline_fh(input, &cmdbuf))
590
exit(128);
591
592
if (!strcmp(cmdbuf.buf, "")) {