@matheusbsbs / matheus-bagliano / commits / b20a60d0c0
Fork 0

diff.c: add "const" qualifier to "char *cmd" member of "struct ll_diff_driver"

Also use "git_config_string" to simplify code where "cmd" is set. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Christian Couder committed Feb 16, 2008 at 06:02 UTC b20a60d0c0f23384cb4141d75d9a7c90e99c1432
1 file changed +2 -5
diff.c
+2 -5
@@ -57,7 +57,7 @@ static int parse_diff_color_slot(const char *var, int ofs)
57 static struct ll_diff_driver {
58 const char *name;
59 struct ll_diff_driver *next;
60 - char *cmd;
60 + const char *cmd;
61 } *user_diff, **user_diff_tail;
62
63 /*
@@ -86,10 +86,7 @@ static int parse_lldiff_command(const char *var, const char *ep, const char *val
86 user_diff_tail = &(drv->next);
87 }
88
89 - if (!value)
90 - return config_error_nonbool(var);
91 - drv->cmd = xstrdup(value);
92 - return 0;
89 + return git_config_string(&(drv->cmd), var, value);
90 }
91
92 /*