@matheusbsbs / matheus-bagliano / commits / b2e5d75d17

tests: mark tests as passing with SANITIZE=leak

When the "ab/various-leak-fixes" topic was merged in [1] only t6021 would fail if the tests were run in the "GIT_TEST_PASSING_SANITIZE_LEAK=check" mode, i.e. to check whether we marked all leak-free tests with "TEST_PASSES_SANITIZE_LEAK=true". Since then we've had various tests starting to pass under SANITIZE=leak. Let's mark those as passing, this is when they started to pass, narrowed down with "git bisect": - t5317-pack-objects-filter-objects.sh: In faebba436e6 (list-objects-filter: plug pattern_list leak, 2022-12-01). - t3210-pack-refs.sh, t5613-info-alternate.sh, t7403-submodule-sync.sh: In 189e97bc4ba (diff: remove parseopts member from struct diff_options, 2022-12-01). - t1408-packed-refs.sh: In ab91f6b7c42 (Merge branch 'rs/diff-parseopts', 2022-12-19). - t0023-crlf-am.sh, t4152-am-subjects.sh, t4254-am-corrupt.sh, t4256-am-format-flowed.sh, t4257-am-interactive.sh, t5403-post-checkout-hook.sh: In a658e881c13 (am: don't pass strvec to apply_parse_options(), 2022-12-13) - t1301-shared-repo.sh, t1302-repo-version.sh: In b07a819c05f (reflog: clear leftovers in reflog_expiry_cleanup(), 2022-12-13). - t1304-default-acl.sh, t1410-reflog.sh, t5330-no-lazy-fetch-with-commit-graph.sh, t5502-quickfetch.sh, t5604-clone-reference.sh, t6014-rev-list-all.sh, t7701-repack-unpack-unreachable.sh: In b0c61be3209 (Merge branch 'rs/reflog-expiry-cleanup', 2022-12-26) - t3800-mktag.sh, t5302-pack-index.sh, t5306-pack-nobase.sh, t5573-pull-verify-signatures.sh, t7612-merge-verify-signatures.sh: In 69bbbe484ba (hash-object: use fsck for object checks, 2023-01-18). - t1451-fsck-buffer.sh: In 8e4309038f0 (fsck: do not assume NUL-termination of buffers, 2023-01-19). - t6501-freshen-objects.sh: In abf2bb895b4 (Merge branch 'jk/hash-object-fsck', 2023-01-30) 1. 9ea1378d046 (Merge branch 'ab/various-leak-fixes', 2022-12-14) Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Ævar Arnfjörð Bjarmason committed Feb 7, 2023 at 00:07 UTC b2e5d75d17c6ba13dc5966692c8ed9c105b4e13a
28 files changed +36
t/t0023-crlf-am.sh
+1
@@ -2,6 +2,7 @@
2
3 test_description='Test am with auto.crlf'
4
5 +TEST_PASSES_SANITIZE_LEAK=true
6 . ./test-lib.sh
7
8 cat >patchfile <<\EOF
t/t1301-shared-repo.sh
+1
@@ -9,6 +9,7 @@ GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
9 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
10
11 TEST_CREATE_REPO_NO_TEMPLATE=1
12 +TEST_PASSES_SANITIZE_LEAK=true
13 . ./test-lib.sh
14
15 # Remove a default ACL from the test dir if possible.
t/t1302-repo-version.sh
+1
@@ -5,6 +5,7 @@
5
6 test_description='Test repository version check'
7
8 +TEST_PASSES_SANITIZE_LEAK=true
9 . ./test-lib.sh
10
11 test_expect_success 'setup' '
t/t1304-default-acl.sh
+1
@@ -9,6 +9,7 @@ test_description='Test repository with default ACL'
9 # => this must come before . ./test-lib.sh
10 umask 077
11
12 +TEST_PASSES_SANITIZE_LEAK=true
13 . ./test-lib.sh
14
15 # We need an arbitrary other user give permission to using ACLs. root
t/t1408-packed-refs.sh
+1
@@ -5,6 +5,7 @@ test_description='packed-refs entries are covered by loose refs'
5 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
6 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
7
8 +TEST_PASSES_SANITIZE_LEAK=true
9 . ./test-lib.sh
10
11 test_expect_success setup '
t/t1410-reflog.sh
+1
@@ -7,6 +7,7 @@ test_description='Test prune and reflog expiration'
7 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
8 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
9
10 +TEST_PASSES_SANITIZE_LEAK=true
11 . ./test-lib.sh
12
13 check_have () {
t/t1451-fsck-buffer.sh
+2
@@ -14,6 +14,8 @@ so.
14 These tests _might_ catch such overruns in normal use, but should be run with
15 ASan or valgrind for more confidence.
16 '
17 +
18 +TEST_PASSES_SANITIZE_LEAK=true
19 . ./test-lib.sh
20
21 # the general idea for tags and commits is to build up the "base" file
t/t3210-pack-refs.sh
+1
@@ -12,6 +12,7 @@ semantic is still the same.
12 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
13 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
14
15 +TEST_PASSES_SANITIZE_LEAK=true
16 . ./test-lib.sh
17
18 test_expect_success 'enable reflogs' '
t/t3800-mktag.sh
+1
@@ -4,6 +4,7 @@
4
5 test_description='git mktag: tag object verify test'
6
7 +TEST_PASSES_SANITIZE_LEAK=true
8 . ./test-lib.sh
9
10 ###########################################################
t/t4152-am-subjects.sh
+2
@@ -1,6 +1,8 @@
1 #!/bin/sh
2
3 test_description='test subject preservation with format-patch | am'
4 +
5 +TEST_PASSES_SANITIZE_LEAK=true
6 . ./test-lib.sh
7
8 make_patches() {
t/t4254-am-corrupt.sh
+2
@@ -1,6 +1,8 @@
1 #!/bin/sh
2
3 test_description='git am with corrupt input'
4 +
5 +TEST_PASSES_SANITIZE_LEAK=true
6 . ./test-lib.sh
7
8 make_mbox_with_nul () {
t/t4256-am-format-flowed.sh
+1
@@ -2,6 +2,7 @@
2
3 test_description='test format=flowed support of git am'
4
5 +TEST_PASSES_SANITIZE_LEAK=true
6 . ./test-lib.sh
7
8 test_expect_success 'setup' '
t/t4257-am-interactive.sh
+2
@@ -1,6 +1,8 @@
1 #!/bin/sh
2
3 test_description='am --interactive tests'
4 +
5 +TEST_PASSES_SANITIZE_LEAK=true
6 . ./test-lib.sh
7
8 test_expect_success 'set up patches to apply' '
t/t5302-pack-index.sh
+2
@@ -4,6 +4,8 @@
4 #
5
6 test_description='pack index with 64-bit offsets and object CRC'
7 +
8 +TEST_PASSES_SANITIZE_LEAK=true
9 . ./test-lib.sh
10
11 test_expect_success 'setup' '
t/t5306-pack-nobase.sh
+2
@@ -6,6 +6,8 @@
6 test_description='git-pack-object with missing base
7
8 '
9 +
10 +TEST_PASSES_SANITIZE_LEAK=true
11 . ./test-lib.sh
12
13 # Create A-B chain
t/t5317-pack-objects-filter-objects.sh
+1
@@ -5,6 +5,7 @@ test_description='git pack-objects using object filtering'
5 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
6 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
7
8 +TEST_PASSES_SANITIZE_LEAK=true
9 . ./test-lib.sh
10
11 # Test blob:none filter.
t/t5330-no-lazy-fetch-with-commit-graph.sh
+1
@@ -2,6 +2,7 @@
2
3 test_description='test for no lazy fetch with the commit-graph'
4
5 +TEST_PASSES_SANITIZE_LEAK=true
6 . ./test-lib.sh
7
8 test_expect_success 'setup: prepare a repository with a commit' '
t/t5403-post-checkout-hook.sh
+1
@@ -7,6 +7,7 @@ test_description='Test the post-checkout hook.'
7 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
8 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
9
10 +TEST_PASSES_SANITIZE_LEAK=true
11 . ./test-lib.sh
12
13 test_expect_success setup '
t/t5502-quickfetch.sh
+1
@@ -5,6 +5,7 @@ test_description='test quickfetch from local'
5 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
6 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
7
8 +TEST_PASSES_SANITIZE_LEAK=true
9 . ./test-lib.sh
10
11 test_expect_success setup '
t/t5573-pull-verify-signatures.sh
+2
@@ -1,6 +1,8 @@
1 #!/bin/sh
2
3 test_description='pull signature verification tests'
4 +
5 +TEST_PASSES_SANITIZE_LEAK=true
6 . ./test-lib.sh
7 . "$TEST_DIRECTORY/lib-gpg.sh"
8
t/t5604-clone-reference.sh
+1
@@ -7,6 +7,7 @@ test_description='test clone --reference'
7 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
8 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
9
10 +TEST_PASSES_SANITIZE_LEAK=true
11 . ./test-lib.sh
12
13 base_dir=$(pwd)
t/t5613-info-alternate.sh
+2
@@ -4,6 +4,8 @@
4 #
5
6 test_description='test transitive info/alternate entries'
7 +
8 +TEST_PASSES_SANITIZE_LEAK=true
9 . ./test-lib.sh
10
11 test_expect_success 'preparing first repository' '
t/t6014-rev-list-all.sh
+1
@@ -2,6 +2,7 @@
2
3 test_description='--all includes detached HEADs'
4
5 +TEST_PASSES_SANITIZE_LEAK=true
6 . ./test-lib.sh
7
8
t/t6021-rev-list-exclude-hidden.sh
+1
@@ -2,6 +2,7 @@
2
3 test_description='git rev-list --exclude-hidden test'
4
5 +TEST_PASSES_SANITIZE_LEAK=true
6 . ./test-lib.sh
7
8 test_expect_success 'setup' '
t/t6501-freshen-objects.sh
+1
@@ -28,6 +28,7 @@ test_description='check pruning of dependent objects'
28 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
29 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
30
31 +TEST_PASSES_SANITIZE_LEAK=true
32 . ./test-lib.sh
33
34 # We care about reachability, so we do not want to use
t/t7403-submodule-sync.sh
+1
@@ -11,6 +11,7 @@ These tests exercise the "git submodule sync" subcommand.
11 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
12 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
13
14 +TEST_PASSES_SANITIZE_LEAK=true
15 . ./test-lib.sh
16
17 test_expect_success setup '
t/t7612-merge-verify-signatures.sh
+1
@@ -4,6 +4,7 @@ test_description='merge signature verification tests'
4 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
5 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
6
7 +TEST_PASSES_SANITIZE_LEAK=true
8 . ./test-lib.sh
9 . "$TEST_DIRECTORY/lib-gpg.sh"
10
t/t7701-repack-unpack-unreachable.sh
+1
@@ -5,6 +5,7 @@ test_description='git repack works correctly'
5 GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
6 export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
7
8 +TEST_PASSES_SANITIZE_LEAK=true
9 . ./test-lib.sh
10
11 fsha1=